Skip to content

Conversation

@tederis
Copy link
Member

@tederis tederis commented Jan 25, 2025

Resolves #3977

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice system of automatic memory cleaning.

botder
botder previously approved these changes Jan 26, 2025
Copy link
Member

@botder botder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think about adding a timer to run CClientRenderElementManager::DoPulse() only every N (milli-)seconds?

@tederis
Copy link
Member Author

tederis commented Jan 28, 2025

LGTM. What do you think about adding a timer to run CClientRenderElementManager::DoPulse() only every N (milli-)seconds?

Yes, it makes sence.

@Dutchman101
Copy link
Member

This is huge, thanks

@Dutchman101 Dutchman101 merged commit f91e1de into multitheftauto:master Jan 28, 2025
3 of 6 checks passed
MTABot pushed a commit that referenced this pull request Jan 28, 2025
@botder botder added this to the 1.6.1 milestone Jan 28, 2025
@botder botder added the enhancement New feature or request label Jan 28, 2025
@tederis tederis deleted the temp_textures_cleanup branch January 29, 2025 06:00
@TheNormalnij TheNormalnij mentioned this pull request Feb 8, 2025
1 task
Dutchman101 added a commit that referenced this pull request Feb 17, 2025
This reverts commit f91e1de.

Details on revert: #4031 (comment) (to find out if it's the original culprit)
MTABot pushed a commit that referenced this pull request Feb 17, 2025
459f6a8 Revert "Temporary textures cleanup (#3978)" This reverts commit f91e1de.
@Dutchman101
Copy link
Member

Temporarily reverted, see details at #4031 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak, temporary textures not deleting

5 participants